Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotfix 1.x #931

Closed
wants to merge 3 commits into from
Closed

Hotfix 1.x #931

wants to merge 3 commits into from

Conversation

ggd543
Copy link

@ggd543 ggd543 commented Apr 26, 2018

@asyncanup asyncanup changed the base branch from v1.0.0 to 1.0.0 April 26, 2018 19:05
@asyncanup
Copy link
Contributor

Instead of commenting, you should delete the line outright, and delete it from the other Error classes as well.
That is, if the issue and PR does get accepted, we would want it to be comprehensive.

@coveralls
Copy link

coveralls commented Jun 23, 2018 •
edited

Coverage Status

Coverage decreased (-0.003%) to 91.715% when pulling fafbab0 on ggd543:hotfix-1.x into 9bccf1f on Netflix:1.0.0.

@ggd543
Copy link
Author

ggd543 commented Jul 12, 2018

@asyncanup I have done what you suggested. Please check it

@asyncanup asyncanup changed the base branch from 1.0.0 to master July 27, 2018 20:36
@asyncanup asyncanup changed the base branch from master to 1.0.0 July 27, 2018 20:37
@asyncanup asyncanup mentioned this pull request Jul 27, 2018
Merged
@asyncanup
Copy link
Contributor

Merged via #938
Thanks @ggd543 !

@asyncanup asyncanup closed this Jul 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ggd543 @asyncanup @coveralls