Remove asap package #969
Merged
Remove asap package #969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 11, 2019 17:02
ASAPScheduler was replaced with TimeoutScheduler(1). It is kept in the repository for backwards compatibility.
tquetano-netflix
approved these changes
Dec 12, 2019
lib/schedulers/ASAPScheduler.js
Outdated
| }; | ||
| // Retained for backwards compatibility | ||
| function ASAPScheduler() { | ||
| return TimeoutScheduler.bind(this, 1)(); |
There was a problem hiding this comment.
Can't this just be TimeoutScheduler.call(this, 1);?
There was a problem hiding this comment.
...yes, it can 🤦♂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The asap package (and its fork, falcor-asap) have occasionally caused issues with our build pipeline. We're not using the scheduler that relies on this package, so I'm removing it.
I kept the ASAPScheduler in the repository, in case anyone imports that file, but it simply forwards to
new TimeoutScheduler(1)now. That scheduler may have slightly different behavior, but it should be similar enough for most use cases.If you still need the exact
asapbehavior, there is a workaround: you can provide a custom scheduler to Falcor.Model.