Fix confusing error when using include and no relationship was set #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you forgot to set any `has_many` in the serializer and tried to serialize with an `include` you would get: ``` NoMethodError (undefined method `[]' for nil:NilClass): ``` That is not very helpful. Setting the variable with a default case makes sure the right error message gets displayed.
|
Is this project still maintained? |
|
@aledalgrande it is maintained. I will take a look at your fix this week and give you a reply. |
|
@aledalgrande thanks for the fix. |
|
Released in Version 1.4 |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you forgot to set any
has_manyin the serializer and tried to serialize with anincludeyou would get:(no backtrace from the gem) That is not very helpful.
Setting the variable with a default case makes sure the right error message gets displayed.