New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The application lacks protection against CSRF #7

Closed
atx opened this Issue Apr 4, 2018 · 3 comments

Comments

Projects
None yet
3 participants
@atx
Copy link

atx commented Apr 4, 2018

The application lacks any sort of protection against CSRF (let alone DNS rebinding).

As some, uhhh, creative development time saving techniques are used, an attacker can execute arbitrary shell commands on the computer running this software by redirecting the users browser to something like:

<a href="http://127.0.0.1:5000/stack/?filename=%3Bxcalc%3Bfoo.gz">Link</a>

@spiermar spiermar added the bug label Apr 4, 2018

@brendangregg brendangregg self-assigned this Apr 4, 2018

brendangregg added a commit that referenced this issue Apr 5, 2018

@brendangregg brendangregg removed their assignment Apr 5, 2018

@brendangregg

This comment has been minimized.

Copy link
Contributor

brendangregg commented Apr 5, 2018

Thanks @atx! I've fixed the filename escapes. We still need to look at the CSRF and DNS rebinding.

@spiermar spiermar added this to the 0.2 milestone Apr 6, 2018

@spiermar

This comment has been minimized.

Copy link
Contributor

spiermar commented Apr 6, 2018

@brendangregg recent PR merge might have fixed a few of those issues.

@spiermar

This comment has been minimized.

Copy link
Contributor

spiermar commented Apr 11, 2018

Assuming this was fixed. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment