Amend the check on IllegalAttachmentFileNameException (#1217)

Co-authored-by: bhou <bhou@netflix.com>
Netflix · May 7, 2024 · 6bad017 · 6bad017
1 parent f53744c
commit 6bad017
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/...c/main/java/com/netflix/genie/web/services/impl/LocalFileSystemAttachmentServiceImpl.java b/...c/main/java/com/netflix/genie/web/services/impl/LocalFileSystemAttachmentServiceImpl.java
@@ -97,9 +97,9 @@ public Set<URI> saveAttachments(
 
                 if (filename != null) {
                     if ((filename.contains("/") || filename.contains("\\")
-                        || filename.equals(".") || filename.equals(".."))) {
+                        || filename.equals(".") || filename.contains(".."))) {
                         throw new IllegalAttachmentFileNameException("Attachment filename " + filename + " is illegal. "
-                            + "Filenames should not be . or .., or contain /, \\.");
+                            + "Filenames should not be ., or contain .., /, \\.");
                     }
 
                     final String attachmentCanonicalPath =

diff --git a/...roovy/com/netflix/genie/web/services/impl/LocalFileSystemAttachmentServiceImplSpec.groovy b/...roovy/com/netflix/genie/web/services/impl/LocalFileSystemAttachmentServiceImplSpec.groovy
@@ -193,7 +193,7 @@ class LocalFileSystemAttachmentServiceImplSpec extends Specification {
         thrown(IllegalAttachmentFileNameException)
     }
 
-    def "reject attachments with illegal filename is .."() {
+    def "reject attachments with illegal filename containing .."() {
         Set<Resource> attachments = new HashSet<Resource>()
         Resource attachment = Mockito.mock(Resource.class)
         Mockito.doReturn("..").when(attachment).getFilename()