Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial Request Tracing Implementation #1093

Merged
merged 6 commits into from
Apr 12, 2021
Merged

Commits on Apr 11, 2021

  1. Miscellaneous changes found during other changes

    - Clean up tests
      - Remove unnecessary integration tests and replace with unit
    - Clean up code formatting
    - Other random things
    tgianos committed Apr 11, 2021
    Configuration menu
    Copy the full SHA
    2d80f0c View commit details
    Browse the repository at this point in the history
  2. Add spring cloud sleuth

    Auto wires in Brave tracing
    Adds hooks for grip tracing in agent and server
    tgianos committed Apr 11, 2021
    Configuration menu
    Copy the full SHA
    4f453c8 View commit details
    Browse the repository at this point in the history
  3. Add components useful for supporting Brave tracing instrumentation wi…

    …thin Genie server and agent
    
    - Trace propagator to be able to put trace information from server to agent and extract it
    - Tag adapter for modifying tags applied to spans that will allow inheritors to adapt tags based on need (e.g. internal netflix tag modifications)
    - Trace cleanup class for synchronously flushing brave spans before agent shut down
    - auto configuration to expose components as beans to be used
    tgianos committed Apr 11, 2021
    Configuration menu
    Copy the full SHA
    879b45f View commit details
    Browse the repository at this point in the history
  4. Add more integrated tracing support to agent

    - Extract Trace information from environment at startup if possible otherwise a new trace will be instantiated
    - close spans at agent termination
    - Add annotations for agent state machine execution
    - Add tag for the genie job id when pertinent
    - Add tag for the agent command that is being executed
    tgianos committed Apr 11, 2021
    Configuration menu
    Copy the full SHA
    51bae48 View commit details
    Browse the repository at this point in the history
  5. Custom Tracing instrumentation for server

    - Propagate trace information from agent launchers into environment variables for agent processes
    - Annotate job launch process to show phases
    - Tag job launch span with job id
    tgianos committed Apr 11, 2021
    Configuration menu
    Copy the full SHA
    1c7a693 View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2021

  1. Propagate trace information into user job environment

    Exported as GENIE_B3_TRACE_ID_HIGH, GENIE_B3_TRACE_ID_LOW, GENIE_B3_PARENT_SPAN_ID and GENIE_B3_SAMPLED environment variables
    Can be used by downstream user job clients to continue to propagate the trace (e.g. to spark or presto, etc)
    tgianos committed Apr 12, 2021
    Configuration menu
    Copy the full SHA
    b8dfd98 View commit details
    Browse the repository at this point in the history