Fix search by tag count queries for commands, clusters and applications #1162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Searching by tags for these entites results in a query using `group by` and `having`. This was working fine for the actual content queries but the count queries were getting messed up because it couldn't count the result properly as it was just and array of 1's being return (counting the group size and all were one). It was actually the length of the result set we'd have wanted for the total count. This wouldn't work though for the ones were tags weren't involved because that query doesn't have a group by and a having. This change modifies the count queries to instead of trying to count directly with the same where predicate it actually counts the results of the real query as a subquery (all on database side so it doesn't return all the data). This way it doesn't matter if there's a `group by` or not. Now the total results returned via the API in the `Page` object are correct and pagination can continue properly.
nvhoang
approved these changes
Mar 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Searching by tags for these entites results in a query using
group byandhaving. This was working fine for the actualcontent queries but the count queries were getting messed up because it couldn't count the result properly as it was just
and array of 1's being return (counting the group size and all were one). It was actually the length of the result set we'd
have wanted for the total count. This wouldn't work though for the ones were tags weren't involved because that query doesn't
have a group by and a having.
This change modifies the count queries to instead of trying to count directly with the same where predicate it actually
counts the results of the real query as a subquery (all on database side so it doesn't return all the data). This way it
doesn't matter if there's a
group byor not. Now the total results returned via the API in thePageobject are correct andpagination can continue properly.