Synchronize Job Coordination #319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lts of the tests that are failing
…time can be scheduled to be launched and we don't blow past the number of running jobs allowed on a node
|
@ajoymajumdar if you have time give this a quick peer review to see if you see any potential issues. |
|
Changes Unknown when pulling bc0076e on 503Test into * on develop*. |
| @@ -49,7 +49,7 @@ public JobCountServiceImpl(@NotNull final JobSearchService jobSearchService, @No | |||
| * {@inheritDoc} | |||
| */ | |||
| @Override | |||
| public int getNumJobs() { | |||
| public synchronized int getNumJobs() { | |||
There was a problem hiding this comment.
Why do you need to synchronize this method?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR synchronizes the entire Job Coordination code to make sure only one job per node can enter that block at a time and all metrics/job counts are consistent before another job is allowed.
This may slow down performance somewhat but the consistency tradeoff should be worth it. Will observe performance change in testing under load.