Refactored ClusterCheckerTask class #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ajoymajumdar
commented
Aug 11, 2016
ajoymajumdar
commented
- Refactored ClusterCheckerTask class
- Mark a node unhealthy if node status is up for all health endpoints excluding a few selected ones like genie,memory.
- Added more error checks.
…01 error the first time. Issue was that while forwarding the request the session cookie was not forwarded.
2. Mark a node unhealthy if node status is up for all health endpoints excluding a few selected ones like genie,memory. 3. Added more error checks.
2. Mark a node unhealthy if node status is up for all health endpoints excluding a few selected ones like genie,memory. 3. Added more error checks.
| @@ -87,6 +97,7 @@ public ClusterCheckerTask( | |||
| @NotNull final JobPersistenceService jobPersistenceService, | |||
| @Qualifier("genieRestTemplate") @NotNull final RestTemplate restTemplate, | |||
| @NotNull final ManagementServerProperties managementServerProperties, | |||
| @Value("${genie.tasks.clusterChecker.ignoreHealthEndPoints:memory,genie}") final String ignoreHealthEndPoints, | |||
There was a problem hiding this comment.
There is only one endpoint I would go with healthIndicatorsToIgnore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.