Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding thymeleaf back in #403

Merged
merged 1 commit into from
Sep 28, 2016
Merged

Adding thymeleaf back in #403

merged 1 commit into from
Sep 28, 2016

Conversation

tgianos
Copy link
Contributor

@tgianos tgianos commented Sep 28, 2016

Needed to load index.html currently.

@tgianos tgianos added the bug label Sep 28, 2016
@tgianos tgianos added this to the 3.0.0 milestone Sep 28, 2016
@tgianos
Copy link
Contributor Author

tgianos commented Sep 28, 2016

@cabhishek this is a temp fix to get us back up and running but you should find a way to get rid of the thymeleaf dependency as we're not actually using any of its functionality and I doubt we need it currently. It's just jar bloat.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 88.436% when pulling e646ebd on tgianos:develop into e1205f5 on Netflix:develop.

Copy link
Contributor

@cabhishek cabhishek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😢

Copy link
Contributor

@cabhishek cabhishek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😢

@tgianos tgianos merged commit 1eac7d7 into Netflix:develop Sep 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants