Removed the inverse relations in the job entities #408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ajoymajumdar
commented
Oct 10, 2016
ajoymajumdar
commented
- Removed the inverse relations in the job entities - JobEntity, JobRequestEntity, JobExecutionEntity and JobMetadataEntity,. This was done to reduce the SQL calls to get the associated entities.
- Modified certain queries to use named queries.
…RequestEntity, JobExecutionEntity and JobMetadataEntity,. This was done to reduce the SQL calls to get the associated entities. 2. Modified certain queries to use named queries.
tgianos
approved these changes
Oct 11, 2016
| */ | ||
| Long deleteByCreatedBefore(@NotNull final Date date); | ||
| List<JobRequestEntity> findByCreatedBefore(@NotNull final Date date); |
There was a problem hiding this comment.
As discussed my only concern here is memory if this list becomes too large. Currently this method is called daily as part of a task so we should be ok but it's something we might want to improve going forward either by returning just the Id's or paginating this list.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.