Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add methods to RunningJob to incrementally update cached stderr and t… #436

Closed
wants to merge 4 commits into from
Closed

Add methods to RunningJob to incrementally update cached stderr and t… #436

wants to merge 4 commits into from

Conversation

atronchi
Copy link

Add methods to RunningJob to incrementally update cached stderr and to tail stderr to the terminal until job completion.

Alexander Tronchin-James and others added 2 commits November 14, 2016 16:40
@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 88.723% when pulling 35368c4 on atronchi:stderr_updates into 03827c3 on Netflix:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 88.688% when pulling 35368c4 on atronchi:stderr_updates into 03827c3 on Netflix:master.

@tgianos tgianos added this to the 3.0.0 milestone Nov 15, 2016
@tgianos
Copy link
Contributor

tgianos commented Dec 8, 2016

@irontable Have you gotten a chance to review this at all?

irontablee
irontablee previously requested changes Dec 9, 2016
View reviewed changes
Copy link
Contributor

@irontablee irontablee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please change the formatting to 4 space indents? Thank you.

Alexander Tronchin-James and others added 2 commits January 2, 2017 20:49
@coveralls
Copy link

Coverage Status

Coverage increased (+0.5%) to 89.234% when pulling f4ef66f on atronchi:stderr_updates into 03827c3 on Netflix:master.

@tgianos tgianos modified the milestones: 3.0.0, 3.1.0 Jan 12, 2017
@irontablee irontablee dismissed their stale review January 17, 2017 22:09

This will be done in a different PR.

@irontablee
Copy link
Contributor

This will be handled in a separate PR.

@irontablee irontablee closed this Jan 17, 2017
@atronchi
Copy link
Author

What is the separate PR for this, so I can follow along?

@irontablee
Copy link
Contributor

@atronchi Sorry for the delay. The PR is at: #459

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@irontablee irontablee irontablee left review comments

Assignees

@irontablee irontablee

Labels
feature
Projects
None yet
Milestone
3.1.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@atronchi @coveralls @tgianos @irontablee