Fix calculation of available job capacity returned in HealthIndicator #503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please pull this against 3.0.x branch to target 3.0.6 release and then cherry pick into master after that. |
|
Closing for the moment. |
tgianos
reviewed
May 15, 2017
| @@ -84,8 +84,8 @@ public Health health() { | |||
| .withDetail(NUMBER_RUNNING_JOBS_KEY, this.jobMetricsService.getNumActiveJobs()) | |||
| .withDetail(USED_MEMORY_KEY, usedMemory) | |||
| .withDetail(AVAILABLE_MEMORY, availableMemory) | |||
| .withDetail(AVAILABLE_DEFAULT_JOB_CAPACITY, availableMemory % defaultJobMemory) | |||
| .withDetail(AVAILABLE_MAX_JOB_CAPACITY, availableMemory % maxJobMemory) | |||
| .withDetail(AVAILABLE_DEFAULT_JOB_CAPACITY, availableMemory / defaultJobMemory) | |||
There was a problem hiding this comment.
Decided not to check divide by zero here?
There was a problem hiding this comment.
Argh, cherry-picked the wrong version of this commit somehow..
Don't merge please.
tgianos
previously approved these changes
May 15, 2017
|
I just reopened this PR which still had the original change i made on master (i.e., no div by zero). |
tgianos
approved these changes
May 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.