Add support for AutoBindSingleton #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…. Add support for AutoBindSingleton.
Optimize the scanning module so class path scanning only happens once
| @@ -7,6 +7,7 @@ dependencies { | |||
| compile "com.google.inject:guice:${guice_version}" | |||
| compile "com.google.inject.extensions:guice-multibindings:${guice_version}" | |||
| compile "com.google.inject.extensions:guice-grapher:${guice_version}" // should be provided - only if you want graphing | |||
| compile "org.ow2.asm:asm:5.0.4" | |||
There was a problem hiding this comment.
asm is fragile since so many things use it; can we use a shaded version, in guice or elsewhere in our dependencies instead?
Change 'default' for AutoBindSingleton value/baseClass to Void (instead of AutoBindSingleton)
This reverts commit 8c0f079.
Upgrade project to Java8 so we can use Java8's functional interfaces
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a general ScanningModuleBuilder with support for class annotations on top of which AutoBindSingleton auto binding is implemented. The resulting module can be installed directly on an injector.