Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compilation of generated files fails if data model object has Byte #176

Closed
akhaku opened this issue Feb 28, 2018 · 0 comments
Closed

Compilation of generated files fails if data model object has Byte #176

akhaku opened this issue Feb 28, 2018 · 0 comments
Assignees
@akhaku
Labels
bug

Comments

@akhaku
Copy link
Contributor

akhaku commented Feb 28, 2018

If you try and generate an API for object that contains a Byte, the generated files to do not compile. Any generated files that to try reference the type (eg HashIndex.java) conflict between my.generated.package.Byte and java.lang.Byte, since we import my.generated.*.

A couple ways to fix this:
@akhaku akhaku self-assigned this Feb 28, 2018
@akhaku akhaku added the bug label Feb 28, 2018
akhaku added a commit to akhaku/hollow that referenced this issue Feb 28, 2018
@akhaku
Use explicit imports instead of start imports for generated types
381a055 
For cases where our generated type matches a java.lang type
(eg Byte), using a star import causes the compiler to get
confused between the generated type and the java.lang type.
Switching to explicit imports makes it clear to the
compiler, so do that.
Fixes Netflix#176.
@akhaku akhaku mentioned this issue Mar 1, 2018
Merged
akhaku added a commit to akhaku/hollow that referenced this issue Mar 1, 2018
@akhaku
Use explicit imports instead of start imports for generated types
26d07a2 
For cases where our generated type matches a java.lang type
(eg Byte), using a star import causes the compiler to get
confused between the generated type and the java.lang type.
Switching to explicit imports makes it clear to the
compiler, so do that.
Fixes Netflix#176.
@akhaku akhaku mentioned this issue Mar 1, 2018
Closed
akhaku added a commit to akhaku/hollow that referenced this issue Mar 1, 2018
@akhaku
Use explicit imports instead of star imports for generated types
bbe3c91 
For cases where our generated type matches a java.lang type
(eg Byte), using a star import causes the compiler to get
confused between the generated type and the java.lang type.
Switching to explicit imports makes it clear to the
compiler, so do that.
Fixes Netflix#176.
akhaku added a commit to akhaku/hollow that referenced this issue Mar 2, 2018
@akhaku
Use explicit imports instead of star imports for generated types
1951a80 
For cases where our generated type matches a java.lang type
(eg Byte), using a star import causes the compiler to get
confused between the generated type and the java.lang type.
Switching to explicit imports makes it clear to the
compiler, so do that.
Fixes Netflix#176.
Sunjeet pushed a commit that referenced this issue Apr 10, 2019
Merge pull request #176 in PDT/cinder from historyProperty to master
fbcad1b 
* commit '4466bb23e8b535e0cada5ce38a1e5e11cfed7e77':
  Adding a property to control if history for previous cycles should be calculated for cinder data module
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@akhaku akhaku

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@akhaku