Bug fix for deleted records being inserted into the write state as Object #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
March 22, 2018 17:30
…ject This caused a restore operation to fail with "java.lang.IllegalStateException: When state engine was restored, not all necessary states were present! Unrestored states: [Object]" Used static DELETE_RECORD object from HollowIncrementalCyclePopulator when adding items to be deleted to the mutations collection Removed misleading DELETE_RECORD from HollowIncrementalProducer
|
@toolbear Please take a look at this bugfix for an issue that was introduced with release v2.9.9 FYI: @rpalcolea @tinetti |
|
@toolbear @dkoszewnik @akhaku Can I get a merge? |
|
Thanks! |
|
@akhaku Thanks for the PR! Do you think these changes could be included in a patch release soon? |
|
Absolutely - planning on doing a release of this and #189 some time today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This caused a restore operation to fail with "java.lang.IllegalStateException: When state engine was restored, not all necessary states were present! Unrestored states: [Object]"
Used static DELETE_RECORD object from HollowIncrementalCyclePopulator when adding items to be deleted to the mutations collection
Removed misleading DELETE_RECORD from HollowIncrementalProducer