Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shard large types #12

Merged
merged 22 commits into from Jan 27, 2017
Merged

Shard large types #12

merged 22 commits into from Jan 27, 2017

Conversation

dkoszewnik
Copy link
Contributor

What was the problem?

Currently, during a delta transition each individual record type builds the entire next state of the type in memory while the current state is retained to answer requests. This means that the memory pool Hollow reserves needs to be large enough to compose an extra copy of the largest type. This is a miniaturized version of the double snapshot problem.

What is the solution?

With this change, large types can be transparently sharded into smaller individual chunks, each of which can update independently. The effect of this change is that Hollow only needs to draw on the memory pool enough to update the largest chunk across all types.

…which had different sharding configurations for one or more types.
…tomatically calculated based on a target excess memory pool size, which defaults to 25MB
…VALUE to disable type sharding by default. This is necessary to ensure backwards compatibility with pre v2.1.0 consumers.
@dkoszewnik dkoszewnik requested a review from a user January 21, 2017 00:02
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Paired with Drew on code review. Looks good.

@dkoszewnik dkoszewnik merged commit 14adb52 into master Jan 27, 2017
@dkoszewnik dkoszewnik deleted the shard-large-types branch January 27, 2017 01:52
Sunjeet pushed a commit that referenced this pull request Apr 10, 2019
…ster

* commit '0fd2b894db703885817168c756f1f3101be1fc6c':
  Add missing PrimaryKeyEntity File
Sunjeet pushed a commit that referenced this pull request Jul 22, 2019
… to master

Squashed commit of the following:

commit 638f64b1cb295e0889d46bab69b2d1a8a46a88df
Author: Paul Sandoz <psandoz@netflix.com>
Date:   Tue Jul 9 14:42:26 2019 -0700

    Refine log level values.

commit ab0cdacfa331d204e1ea6bafee1d22dc4e122491
Author: Paul Sandoz <psandoz@netflix.com>
Date:   Mon Jul 8 09:25:30 2019 -0700

    Refactor command options.

    - Lower case environment options and remove "local_" prefix.

    - Replace general verbose option with logging and levels.

    - Move port from general options to explore/history/diff.

    - Change graph output to format.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant