Fix integer overflow in more offset calculations

[ghost]

Fixing more cases of integer overflow similar to those fixed in #222.

• identify potential overflow and upcast to long

  • idiom 1: ordinal * bitsPerX where both are int; can be bucket or element in addition to ordinal
  • idiom 2: ordinal + N where ordinal is assigned to a long or passed as an argument that accepts longs
    • doesn't include BitSet which only works with int indices; this is one of the reasons ordinals are currently limited to integers

• standardize style on (long)ordinal * bitsPerX to make it easier to spot the common pattern and notice missing upcasts

  • replace: (long)bitsPerX * ordinal, bitsPerX * (long)ordinal, or (long)bitsPerX * (long)ordinal
  • replace: ordinal * (long)bitsPerX or (long)ordinal * (long)bitsPerX
  • avoid redundant upcast; in some cases ordinal is already a long temporary variable or passed as long to a private helper; public APIs should only pass ordinal as int to avoid confusion

• review com.netflix.hollow.core.read.engine

  • review list.*
  • review set.*
  • review map.*
  • review object.*

[ghost]

/cc @adamkeyser @manuelq

[rpalcolea]

This looks great! hopefully we can get a release soon :)

[manuelq]

@toolbear
We tested this branch out locally with this test below added to HollowListFastDeltaTest and it works great. This takes about 2 minutes to run locally so not sure if this could be added to the suite but it's a good verification.

@Test
    public void testLarge() throws IOException {
        int listOrdinal = 0;        //2147483647 MAX INT
        int totalRecords = 0;       // WHY 79536431 because bitsPerListPointer = 27 so MaxINT/27
        for(int ordinal = 0; ordinal <= 79536431;ordinal++){
            addRecord(listOrdinal++);
            totalRecords++;

        }
        //Just add another 100k
        System.out.println(totalRecords);
        for(int ordinal = 0; ordinal <= 100000;ordinal++){
            addRecord(listOrdinal++);
            totalRecords++;
        }
        System.out.println(totalRecords);
        roundTripSnapshot();

        HollowListTypeReadState typeState = (HollowListTypeReadState) readStateEngine.getTypeState("TestList");

        assertList(typeState, 14, 14);

        assertList(typeState, 79636430, 79636430);
        HollowChecksum checksum = typeState.getChecksum(readStateEngine.getSchema("TestList"));
        checksum.intValue();
    }

[manuelq]

On the master branch the test above throws

java.lang.ArrayIndexOutOfBoundsException: -130908

	at com.netflix.hollow.core.memory.encoding.FixedLengthElementArray.getElementValue(FixedLengthElementArray.java:93)
	at com.netflix.hollow.core.memory.encoding.FixedLengthElementArray.getElementValue(FixedLengthElementArray.java:84)
	at com.netflix.hollow.core.read.engine.list.HollowListTypeReadStateShard.size(HollowListTypeReadStateShard.java:73)
	at com.netflix.hollow.core.read.engine.list.HollowListTypeReadState.size(HollowListTypeReadState.java:143)
	at com.netflix.hollow.core.read.iterator.HollowListOrdinalIterator.<init>(HollowListOrdinalIterator.java:32)
	at com.netflix.hollow.core.read.engine.list.HollowListTypeReadState.ordinalIterator(HollowListTypeReadState.java:150)
	at com.netflix.hollow.core.read.list.HollowListFastDeltaTest.assertList(HollowListFastDeltaTest.java:161)
	at com.netflix.hollow.core.read.list.HollowListFastDeltaTest.testLarge(HollowListFastDeltaTest.java:145)```