Producer Listener support refactored for code reuse #448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
approved these changes
Feb 5, 2020
akhaku
approved these changes
Feb 6, 2020
| ListenerSupport(ListenerSupport that) { | ||
| eventListeners = new CopyOnWriteArrayList<>(that.eventListeners); | ||
| ProducerListenerSupport(ProducerListenerSupport that) { | ||
| super(); |
There was a problem hiding this comment.
did you mean to pass in that to the super call here?
There was a problem hiding this comment.
Yes, thanks for that
| ListenerSupport() { | ||
| eventListeners = new CopyOnWriteArrayList<>(); | ||
| ProducerListenerSupport() { | ||
| super(); |
There was a problem hiding this comment.
Super minor, but I think the no-argument super call is implicit.
zurdoron
pushed a commit
to zurdoron/hollow
that referenced
this pull request
Jul 27, 2020
* Producer Listener support refactored * Address PR feedback (cherry picked from commit b080244)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For reuse in abstractions that compose a producer (eg. transformer).
Note the following breaking changes:
final class ListenerSupport->final class ProducerListenerSupport extends ListenerSupportpublic interface HollowProducerEventListener->public interface HollowProducerEventListener extends EventListener