Support byte[] in @HollowPrimaryKey for ObjectInternPool in HollowHistoryUI #664
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When loading states with byte[] as the primary key in Hollow, the
ObjectInternPool
throws anIllegalArgumentException
. This issue occurs because the current implementation ofObjectInternPool
does not support interning objects of typebyte[]
, which is needed byHollowHistoryUI
.The proposed solution extends the
ObjectInternPool
functionality to handlebyte[]
effectively, allowingHollowHistoryUI
to intern these objects without errors.Current implementation throws exception: