Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup setup.py #3116

Merged
merged 7 commits into from
Sep 2, 2020
Merged

Cleanup setup.py #3116

merged 7 commits into from
Sep 2, 2020

Conversation

csine-pro
Copy link
Contributor

@csine-pro csine-pro commented Sep 1, 2020 •
edited

This PR makes several changes to setup.py

  • Removes dependencies on pip, sys, and distutils
  • Removes all the requirements parsing spaghetti logic with simpler flow.
  • Relies on logger instead of distutils.log

@csine-pro csine-pro changed the title fixing import order to fix travis builds Fixing distutils/setuptools issue causing travis to break Sep 1, 2020
hosseinsh
hosseinsh approved these changes Sep 1, 2020
View reviewed changes
Copy link
Contributor

@hosseinsh hosseinsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice job

@coveralls
Copy link

coveralls commented Sep 2, 2020 •
edited

Coverage Status

Coverage remained the same at 57.922% when pulling ef6373c on fix_distutils into 5dd6c66 on master.

@csine-pro csine-pro changed the title Fixing distutils/setuptools issue causing travis to break Cleanup setup.py Sep 2, 2020
@csine-pro csine-pro merged commit 9ded7b8 into master Sep 2, 2020
@csine-pro csine-pro deleted the fix_distutils branch September 2, 2020 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hosseinsh hosseinsh hosseinsh approved these changes

@charhate charhate charhate approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@csine-pro @coveralls @hosseinsh @charhate