Allow filtering with SAN in certificates/valid endpoint #4738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charhate
requested review from
hosseinsh,
jtschladen,
douglasc-nflx and
jmcrawford45
as code owners
jtschladen
reviewed
Dec 12, 2023
jtschladen
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added supported to filter with a SAN. This is useful for the certs without CN, as CN could be optional.
Lookup could be extended to support lookup by multiple hostnames/SAN instead of just one. However, given the fact that domain table does not hold unique entries, performance will degrade when filtered with many SANs. Thus keeping it simple for now.