Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fall back to CN for CA name when organization is not available #607

Merged
merged 1 commit into from
Dec 17, 2016

Conversation

intgr
Copy link
Contributor

@intgr intgr commented Dec 15, 2016

In-house CAs may not have the organization field filled out.

In-house CAs may not have the organization field filled out.
@kevgliss
Copy link
Contributor

Organization should be set either via the LEMUR_DEFAULT_ORGANIZATION or via the UI. Is the use case that: it is not set, it cannot be set or it should be set dynamically?

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.006%) to 68.266% when pulling be7673a on intgr:ca-name-cn into 156b98f on Netflix:master.

@intgr
Copy link
Contributor Author

intgr commented Dec 16, 2016

The use case is importing legacy CA certificates into Lemur. I can't change them.

@kevgliss
Copy link
Contributor

Makes sense. Cheers.

@kevgliss kevgliss merged commit 0f3ffaa into Netflix:master Dec 17, 2016
chadhendrie pushed a commit to thomsonreuters/lemur that referenced this pull request Dec 21, 2016
…ix#607)

In-house CAs may not have the organization field filled out.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants