Perform conversions from microsecond to second correctly (#507)

* Perform conversions from microsecond to second correctly * Whatever --------- Co-authored-by: Sundaram Ananthanarayanan <sananthanarayanan@netflix.com>
Netflix · Aug 1, 2023 · d0251c4 · d0251c4
1 parent f9a3261
commit d0251c4
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/...gent/src/main/java/io/mantisrx/server/agent/metrics/cgroups/CpuAcctsSubsystemProcess.java b/...gent/src/main/java/io/mantisrx/server/agent/metrics/cgroups/CpuAcctsSubsystemProcess.java
@@ -74,8 +74,8 @@ private void handleV1(Usage.UsageBuilder resourceUsageBuilder) throws IOExceptio
     private void handleV2(Usage.UsageBuilder resourceUsageBuilder) throws IOException {
         Map<String, Long> cpuStats = cgroup.getStats("", "cpu.stat");
         resourceUsageBuilder
-            .cpusUserTimeSecs(cpuStats.getOrDefault("user_usec", 0L) / 1000.0)
-            .cpusSystemTimeSecs(cpuStats.getOrDefault("system_usec", 0L) / 1000.0);
+            .cpusUserTimeSecs(cpuStats.getOrDefault("user_usec", 0L) / 1000_000.0)
+            .cpusSystemTimeSecs(cpuStats.getOrDefault("system_usec", 0L) / 1000_000.0);
 
         List<Long> metrics = cgroup.getMetrics("", "cpu.max");
         if (metrics.size() != 2) {

diff --git a/.../src/test/java/io/mantisrx/server/agent/metrics/cgroups/TestCpuAcctsSubsystemProcess.java b/.../src/test/java/io/mantisrx/server/agent/metrics/cgroups/TestCpuAcctsSubsystemProcess.java
@@ -63,7 +63,7 @@ public void testCgroupsV2() throws IOException {
         process.getUsage(usageBuilder);
         final Usage usage = usageBuilder.build();
         assertEquals(2L, (long) usage.getCpusLimit());
-        assertEquals(4231313L, (long) usage.getCpusUserTimeSecs());
-        assertEquals(1277084L, (long) usage.getCpusSystemTimeSecs());
+        assertEquals(4231L, (long) usage.getCpusUserTimeSecs());
+        assertEquals(1277L, (long) usage.getCpusSystemTimeSecs());
     }
 }