Fix double comp #646
Merged
Fix double comp #646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fdc-ntflx
requested review from
calvin681,
sundargates,
Andyz26 and
hmitnflx
as code owners
fdc-ntflx
had a problem deploying
to
Integrate Pull Request
GitHub Actions
Failure
Andyz26
approved these changes
Mar 18, 2024
| @@ -611,7 +612,7 @@ private Optional<TaskExecutorGroupKey> findBestGroupByFitnessCalculator(Scheduli | |||
| // one with size and one without. Due to this, issues may arise during task migrations as it's not | |||
| // predictable which TEs will be chosen by the scheduler. While, instead, we want to always use TEs from the latest ASGs. | |||
| .sorted((entry1, entry2) -> { | |||
| int fitnessComparison = entry2.getValue().compareTo(entry1.getValue()); | |||
| int fitnessComparison = DoublePrecisionComparator.compare(entry2.getValue(), entry1.getValue()); | |||
Andyz26
reviewed
Mar 18, 2024
| public static int compare(Double value1, Double value2) { | ||
| double valueDifference = value1 - value2; | ||
|
|
||
| if (Math.abs(valueDifference) < 1E-14) { |
There was a problem hiding this comment.
btw do we need such high precision on these?
fdc-ntflx
force-pushed
the
fix-double-comp
branch
from
51737d9
to
988abfa
Compare
fdc-ntflx
had a problem deploying
to
Integrate Pull Request
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Explain context and other details for this pull request.
Checklist
./gradlew buildcompiles code correctly./gradlew testpasses all tests