[Ready for review] update UI to search foreach stack #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darinyu
changed the title
obgibson
reviewed
Jan 23, 2024
src/hooks/useSearchRequest/index.tsx
Outdated
| export const parseSearchValue = (searchValue: string): SearchTerm | null => { | ||
| const scope: string[] = []; | ||
| if (FEATURE_FLAGS.ARTIFACT_SEARCH) { | ||
| scope.push('ARTIFACT'); |
There was a problem hiding this comment.
What do these strings mean? Can we use an enumerator or symbol for them?
There was a problem hiding this comment.
We use feature flag to control whether we want to search for artifact or foreach (flag is by default false, and no search box will show)
the value of this "scope" will be parsed in backend, and filter tasks accordingly.
There was a problem hiding this comment.
If there are a limited set of possible values, it would be nice to restrict the type to those values, rather than allow any string
obgibson
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements for a pull request
Fill out the template below. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
Description of the Change
This is to surface the changes to search for foreach tasks (related PR in metaflow and metaflow-service).
Similar to artifact search, this is behind flags and default to off.
Alternate Designs
-
Possible Drawbacks
-
Verification Process
Verified that search box works by searching "key" or "key=value".
Release Notes
Added option to search for foreach argument and value to identify task faster.