Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore:Format all icon SVGs #36

Merged
merged 2 commits into from
Nov 18, 2021
Merged

chore:Format all icon SVGs #36

merged 2 commits into from
Nov 18, 2021

Conversation

rsanteri
Copy link
Contributor

Requirements for a pull request

  • Unit tests related to the change have been updated
  • Documentation related to the change has been updated

Description of the Change

SVGs were unformatted. Might as well format them as all the other files

@obgibson
Copy link
Collaborator

You need to remove the ; at the end of each svg file - s/<\/svg>;/<\/svg>/g or equivalent

@rsanteri rsanteri marked this pull request as draft November 18, 2021 08:44
@rsanteri rsanteri closed this Nov 18, 2021
@rsanteri rsanteri reopened this Nov 18, 2021
@rsanteri rsanteri marked this pull request as ready for review November 18, 2021 11:05
@obgibson obgibson merged commit fd63fdc into master Nov 18, 2021
@obgibson obgibson deleted the chore/format-icons branch November 18, 2021 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@obgibson obgibson obgibson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rsanteri @obgibson