Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add status to card loading #57

Merged
merged 2 commits into from
Jan 24, 2022
Merged

Add status to card loading #57

merged 2 commits into from
Jan 24, 2022

Conversation

obgibson
Copy link
Collaborator

@obgibson obgibson commented Jan 21, 2022

Requirements for a pull request

  • Unit tests related to the change have been updated
  • Documentation related to the change has been updated

Description of the Change

Adds a status to the return value from the useTaskCards() hook so that the status can show in the UI.

Possible Drawbacks

More visual noise on the page.

Verification Process

  • Load MFGUI
  • Start a flow with a number of tasks (preferably slow)
  • Navigate to a recently started task in MFGUI
  • Note the "loading" indicators
  • Note the card appearing

Screen Shot 2022-01-21 at 3 19 36 PM


  • Bork your metaflow-service (e.g. by switching to a branch that doesn't support cards)
  • Load MFGUI
  • Start a flow with a number of tasks (preferably slow)
  • Navigate to a recently started task in MFGUI
  • Note the "loading" indicators
  • Note the card timeout message

Screen Shot 2022-01-21 at 3 22 34 PM

Release Notes

Shows status when loading cards

@obgibson obgibson merged commit 3f454f9 into master Jan 24, 2022
@obgibson obgibson deleted the fix/card-status branch January 24, 2022 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants