Skip to content

Commit

Permalink
cleanup
Browse files Browse the repository at this point in the history
  • Loading branch information
saikonen committed Jan 27, 2024
1 parent 9ad36fe commit d7a320b
Showing 1 changed file with 0 additions and 10 deletions.
10 changes: 0 additions & 10 deletions metaflow/plugins/argo/argo_workflows.py
Original file line number Diff line number Diff line change
Expand Up @@ -1141,16 +1141,6 @@ def _container_templates(self):
# we need to use the split index in case this is the last step in a nested foreach
task_idx = "{{inputs.parameters.split-index}}"
root_input = "{{inputs.parameters.root-input-path}}"
# if (
# node.type == "join"
# and self.graph[node.split_parents[-1]].type == "foreach"
# and not node.is_inside_foreach
# ):
# # disambiguate root foreach join task_id, as the input-paths will not contain enough entropy otherwise.
# # only do this for joins of foreach, not static splits.
# # TODO: Is this even necessary?
# # task_str += "{{inputs.parameters.max-split}}"
# pass

# Task string to be hashed into an ID
task_str = "-".join(
Expand Down

0 comments on commit d7a320b

Please sign in to comment.