Initialize datastore_root from cli args in cli.step(...) #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gitter thread - https://gitter.im/metaflow_org/community?at=5e4b8e24d56ddb68a4aff877 Metaflow initializes datastore_root to fetch user code in `step` command. The behaviour defaults to relying on METAFLOW_DATASTORE_SYSROOT_S3 environment variable to initialize datastore_root. This patch checks if --datastore_root cli arg can be used instead.
crk-codaio
reviewed
Feb 18, 2020
metaflow/cli.py
Outdated
Comment on lines
769
to
770
| if datastore_root is None: | ||
| datastore_root = ctx.obj.datastore.get_datastore_root_from_config(echo) |
There was a problem hiding this comment.
Discussed offline - I think each of the terminal commands like step, dump etc. probably handle if datastore_root is None so we should be able to safely remove this if check.
There was a problem hiding this comment.
Made the change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gitter thread - https://gitter.im/metaflow_org/community?at=5e4b8e24d56ddb68a4aff877
Metaflow initializes datastore_root to fetch user code in
stepcommand. The behaviour defaults to relying on METAFLOW_DATASTORE_SYSROOT_S3 environment variable to initialize datastore_root. This patch checks if --datastore_root cli arg can be used instead.