Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize datastore_root from cli args in cli.step(...) #134

Merged
merged 2 commits into from Feb 18, 2020
Merged

Initialize datastore_root from cli args in cli.step(...) #134

merged 2 commits into from Feb 18, 2020

Conversation

savingoyal
Copy link
Collaborator

@savingoyal savingoyal commented Feb 18, 2020

Gitter thread - https://gitter.im/metaflow_org/community?at=5e4b8e24d56ddb68a4aff877

Metaflow initializes datastore_root to fetch user code in step command. The behaviour defaults to relying on METAFLOW_DATASTORE_SYSROOT_S3 environment variable to initialize datastore_root. This patch checks if --datastore_root cli arg can be used instead.

Gitter thread - https://gitter.im/metaflow_org/community?at=5e4b8e24d56ddb68a4aff877

Metaflow initializes datastore_root to fetch user code in `step`
command. The behaviour defaults to relying on METAFLOW_DATASTORE_SYSROOT_S3
environment variable to initialize datastore_root. This patch checks if
--datastore_root cli arg can be used instead.
@savingoyal savingoyal requested a review from tuulos Feb 18, 2020
metaflow/cli.py Outdated
if datastore_root is None:
datastore_root = ctx.obj.datastore.get_datastore_root_from_config(echo)
Copy link
Contributor

@crk-codaio crk-codaio Feb 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed offline - I think each of the terminal commands like step, dump etc. probably handle if datastore_root is None so we should be able to safely remove this if check.

Copy link
Collaborator Author

@savingoyal savingoyal Feb 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made the change.

@savingoyal savingoyal merged commit 84b3390 into master Feb 18, 2020
2 checks passed
@savingoyal savingoyal deleted the cli branch Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants