Fix an issue when LD_LIBRARY_PATH is overriden in a Conda environment #1540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In a Conda environment, it is sometimes necessary to set LD_LIBRARY_PATH to first include the Conda's environment libraries before anything else. This, however, causes problems with the escape hatch which uses this same modified LD_LIBRARY_PATH *outside* of the Conda environment. This patch fixes this issue by using the convention that, if a Conda environment modifies LD_LIBRARY_PATH, it will save the original LD_LIBRARY_PATH in MF_ORIG_LD_LIBRARY_PATH.
emattia
pushed a commit
to emattia/metaflow
that referenced
this pull request
Sep 17, 2023
…Netflix#1540) In a Conda environment, it is sometimes necessary to set LD_LIBRARY_PATH to first include the Conda's environment libraries before anything else. This, however, causes problems with the escape hatch which uses this same modified LD_LIBRARY_PATH *outside* of the Conda environment. This patch fixes this issue by using the convention that, if a Conda environment modifies LD_LIBRARY_PATH, it will save the original LD_LIBRARY_PATH in MF_ORIG_LD_LIBRARY_PATH.
savingoyal
pushed a commit
that referenced
this pull request
Sep 27, 2023
…#1540) In a Conda environment, it is sometimes necessary to set LD_LIBRARY_PATH to first include the Conda's environment libraries before anything else. This, however, causes problems with the escape hatch which uses this same modified LD_LIBRARY_PATH *outside* of the Conda environment. This patch fixes this issue by using the convention that, if a Conda environment modifies LD_LIBRARY_PATH, it will save the original LD_LIBRARY_PATH in MF_ORIG_LD_LIBRARY_PATH.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a Conda environment, it is sometimes necessary to set LD_LIBRARY_PATH to first include the Conda's environment libraries before anything else.
This, however, causes problems with the escape hatch which uses this same modified LD_LIBRARY_PATH outside of the Conda environment. This patch fixes this issue by using the convention that, if a Conda environment modifies LD_LIBRARY_PATH, it will save the original LD_LIBRARY_PATH in MF_ORIG_LD_LIBRARY_PATH.