Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[@card] Realtime cards (1/N) #1550

Merged
merged 18 commits into from
Dec 5, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
a2adc21
[current.card.refresh] refactor cards to support runtime updates
tuulos Aug 6, 2023
54e637f
[card-refresh] implement card reload policy
tuulos Aug 6, 2023
a81af50
[current.card.components] card component refresh
valayDave Sep 26, 2023
63ced81
[card-creator] decouple decorator code from card creation
valayDave Sep 26, 2023
80a34eb
Refactor based on comments + bug fixes + handle more edge cases:
valayDave Oct 18, 2023
198d3df
[card-client][card-datastore] data read methods
valayDave Oct 17, 2023
2bfe12f
[card][tests] verify the behavior of `.refresh` / `.components`
valayDave Oct 25, 2023
93137fe
[card-components][core-change][MET-113]
valayDave Nov 20, 2023
7653366
[card-decorator][MET-103] refresh-interval
valayDave Nov 21, 2023
6edba98
[card-client][MET-106] Card.get_data as public fn
valayDave Nov 21, 2023
2217d3d
[card-cli][MET-105] Simplify timeout logic
valayDave Nov 21, 2023
3afe942
[card-core][chore][MET-111] Remove unsed imports
valayDave Nov 21, 2023
20532ce
[card-datastore][MET-108] simplify path creation logic
valayDave Nov 21, 2023
4e7f32d
[component-serializer][MET-108] simplify component storage logic
valayDave Nov 21, 2023
e606e14
[card-creator][MET-109] Fix race-condition btw async/sync card create…
valayDave Nov 21, 2023
d9c1437
[card-client][MET-117] remove from_resumed and rather derive it from …
valayDave Nov 21, 2023
0005550
[cleanup][MET-107] typo / hygiene
valayDave Nov 21, 2023
a719a43
[card-core][MET-104] revert `MetaflowCard.render` signature to original
valayDave Nov 21, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions metaflow/metaflow_config.py
Original file line number Diff line number Diff line change
Expand Up @@ -165,6 +165,8 @@

SKIP_CARD_DUALWRITE = from_conf("SKIP_CARD_DUALWRITE", False)

RUNTIME_CARD_RENDER_INTERVAL = from_conf("RUNTIME_CARD_RENDER_INTERVAL", 60)

# Azure storage account URL
AZURE_STORAGE_BLOB_SERVICE_ENDPOINT = from_conf("AZURE_STORAGE_BLOB_SERVICE_ENDPOINT")

Expand Down
4 changes: 4 additions & 0 deletions metaflow/plugins/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,8 @@ def get_plugin_cli():
TestNonEditableCard,
TestPathSpecCard,
TestTimeoutCard,
TestRefreshCard,
TestRefreshComponentCard,
)

CARDS = [
Expand All @@ -182,5 +184,7 @@ def get_plugin_cli():
TestNonEditableCard,
BlankCard,
DefaultCardJSON,
TestRefreshCard,
TestRefreshComponentCard,
]
merge_lists(CARDS, MF_EXTERNAL_CARDS, "type")