fix timezone in default card time format string #1575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valayDave
previously approved these changes
Oct 10, 2023
| @@ -365,7 +365,7 @@ def _parse_pandas_dataframe(self, data_object, truncate=True): | |||
| if truncate: | |||
| data = data_object.head() | |||
| index_column = data.index | |||
| time_format = "%Y-%m-%dT%H:%M:%SZ" | |||
| time_format = "%Y-%m-%dT%H:%M:%S%Z" | |||
There was a problem hiding this comment.
It is safe to remove this since #1574 already handles the index case.
amerberg
force-pushed
the
fix-card-timezone-format
branch
from
a9e09cb
to
8f68fbe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default card formats timezones in dataframes with
time_format = "%Y-%m-%dT%H:%M:%SZ". This should betime_format = "%Y-%m-%dT%H:%M:%S%Z"; without the % before the Z the formatted time will end with the literal Z, which means UTC time.