Remove use of distutils from code (not setup.py yet) #1585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also improve performance by removing pkg_resources and replacing with another way of getting the package version. Finally, remove spurious includes that have no business being there :)
savingoyal
reviewed
Oct 18, 2023
savingoyal
previously approved these changes
Oct 18, 2023
|
@romain-intel can you introduce tests for 3.12 as part of this PR - https://github.com/Netflix/metaflow/blob/master/.github/workflows/test.yml#L28 |
saikonen
reviewed
Oct 24, 2023
This was referenced Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also improve performance by removing pkg_resources and replacing with another way of getting the package version.
Finally, remove spurious includes that have no business being there :)