Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pypi environment issues #1623

Merged
merged 1 commit into from Nov 3, 2023

Conversation

saikonen
Copy link
Collaborator

@saikonen saikonen commented Nov 2, 2023

fixes logic introduced in #1595 which incorrectly evaluates any @pypi environment as disabled.

tested with

from metaflow import step, FlowSpec, pypi, pypi_base, conda, conda_base

class EnvTest(FlowSpec):
    @pypi
    @step
    def start(self):
        print("Starting 馃憢")
        import sys
        print(sys.executable)
        print(sys.path)
        self.next(self.end)

    @step
    def end(self):
        print("Done! 馃弫")


if __name__ == "__main__":
    EnvTest()

which should include the micromamba environment and Python executable (before this PR it would only point to the host Python)

Resolves #1605

@savingoyal savingoyal merged commit 190b504 into master Nov 3, 2023
22 checks passed
@savingoyal savingoyal deleted the fix/issue-with-explicit-pypi-decorator branch November 3, 2023 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pypi trouble - ModuleNotFoundError
2 participants