Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: conda environment counts as disabled with implicit decorator #1668

Merged
merged 1 commit into from Jan 8, 2024

Conversation

saikonen
Copy link
Collaborator

@saikonen saikonen commented Jan 8, 2024

Fixes issue where conda environments are wrongly treated as disabled if the decorator is implicitly applied.

The underlying reason is that due to the lifecycle of decorators, the disabled attribute gets cast to string early enough, that the is_disabled check fails.

Can test this by slapping the following at the end of step_init in conda decorator

print(f"has conda decorator: {step} - disabled: {self.disabled} - type: {type(self.disabled)}")

closes #1667

@savingoyal savingoyal merged commit 60a8caf into master Jan 8, 2024
22 checks passed
@savingoyal savingoyal deleted the fix/conda-environment-disable-issue branch January 8, 2024 14:47
madhur-ob pushed a commit to madhur-ob/metaflow that referenced this pull request Jan 18, 2024
emattia pushed a commit to emattia/metaflow that referenced this pull request Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Conda environment being treated as disabled, and not appending environment to PATH.
2 participants