[realtime-card] pre-release bug Fixes. #1686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Allow vega chart update method to even accept an altair chart.
- If a markdown component contains a paragraph then `svelte-markdown` doesn't end up rendering appropriately during data update calls. It renders empty `<p>` tags. - Adding a new line at the start of markdown text will ensure all markdown which contains paragraphs is rendered correctly during data update calls.
savingoyal
approved these changes
Jan 15, 2024
madhur-ob
pushed a commit
to madhur-ob/metaflow
that referenced
this pull request
Jan 18, 2024
* [@card] add viewer file into manifests * [card-components] docstring + vega chart tweeks - Allow vega chart update method to even accept an altair chart. * [card-components] Markdown paragraph text bug fix - If a markdown component contains a paragraph then `svelte-markdown` doesn't end up rendering appropriately during data update calls. It renders empty `<p>` tags. - Adding a new line at the start of markdown text will ensure all markdown which contains paragraphs is rendered correctly during data update calls.
emattia
pushed a commit
to emattia/metaflow
that referenced
this pull request
Jan 23, 2024
* [@card] add viewer file into manifests * [card-components] docstring + vega chart tweeks - Allow vega chart update method to even accept an altair chart. * [card-components] Markdown paragraph text bug fix - If a markdown component contains a paragraph then `svelte-markdown` doesn't end up rendering appropriately during data update calls. It renders empty `<p>` tags. - Adding a new line at the start of markdown text will ensure all markdown which contains paragraphs is rendered correctly during data update calls.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Manifest Changes
add viewer HTML file into manifests
Vega Chart
Update function also supports providing Altair chart.
Docstring
Markdown paragraph text bug fix
svelte-markdowndoesn't end up rendering appropriately during data update calls. It renders empty<p>tags.