allow multiple environment decorators #1785
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow multiple environment decorators on a step. This is helpful when a user wants to set some environment variables in code and others from the CLI using
--with
. When multiple environment decorators are supplied, thevars
for each decorator are set in order. A message is logged in the case of conflicting values.I've tested with the following example flow:
I've run
--with environment:vars='{"VAR1":"val4", "VAR2":"val3"}'
both locally and on Argo Workflows. Environment variables have the correct values in both cases, though in the case of Argo, the messages about the conflicting values are logged whenargo-workflows create
is run, rather than when the workflow is run.