[Ready for Review] add attempt_ok flag so that UI will not show up unknown node #1830
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This
attempt_ok
attribute is not used within metaflow runtime but is needed for UI to correctly display the status of a node. For example, in metaflow-service repo here, ifattempt_ok
is not set, then the status become unknown.For example, like this:
![metaflow-unknown](https://private-user-images.githubusercontent.com/5545942/329128710-c14104ab-6447-4a59-bd81-e170f3d98a53.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjMwOTAxMTQsIm5iZiI6MTcyMzA4OTgxNCwicGF0aCI6Ii81NTQ1OTQyLzMyOTEyODcxMC1jMTQxMDRhYi02NDQ3LTRhNTktYmQ4MS1lMTcwZjNkOThhNTMucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDgwOCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA4MDhUMDQwMzM0WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9NzY1OGUwZGYxMThlZDc0NTVjZWJiYzlhMjZmMGRmYmYzZjViZmUwMDAyZWY0NjljZTE4YzBlMjY5YWU1NDAyNyZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.pa9OeAmoxzt5LZkjYPyAghwtc3Qq1bad0L0lPAX9S3w)