Fix/remember namespace #1873
Merged
Fix/remember namespace #1873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This would fix the following issue:
namespace("B")
r = Run("myFlow/123") # r in namespace B
namespace("A")
r["end"] # Currently does not work -- this would make it work
romain-intel
force-pushed
the
fix/remember-namespace
branch
from
d194f50
to
b9fffe5
Compare
savingoyal
requested changes
Jun 6, 2024
metaflow/client/core.py
Outdated
| @@ -268,11 +268,13 @@ def __init__( | |||
| _object: Optional["MetaflowObject"] = None, | |||
| _parent: Optional["MetaflowObject"] = None, | |||
| _namespace_check: bool = True, | |||
| _create_namespace: Optional[str] = None, | |||
There was a problem hiding this comment.
minor nit - this can be _current_namespace to aid readability
|
Approved offline by @savingoyal |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.