K8S: RFC-1123 compliant job names #712
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oavdeev
changed the title
oavdeev
changed the title
oavdeev
changed the title
savingoyal
requested changes
Sep 22, 2021
| """ Generate RFC 1123 compatible job name """ | ||
| long_name = "-".join( | ||
| [ | ||
| flow_name, |
There was a problem hiding this comment.
Technically flow_name can start with an underscore, which will make the output of this function non-compliant.
Also, we would need to sanitize the strings for labels as well - we can (at a later stage) make this a utility method.
There was a problem hiding this comment.
Fixed. Also I realized that the previous version could generate identical names for HelloFlow and Helloflow, fixed that too
oavdeev
force-pushed
the
rfc-1123-job-names
branch
2 times, most recently
from
48abada
to
1a6c4a6
Compare
oavdeev
force-pushed
the
rfc-1123-job-names
branch
from
1a6c4a6
to
5e0c497
Compare
oavdeev
force-pushed
the
rfc-1123-job-names
branch
2 times, most recently
from
be2f658
to
78d66e9
Compare
|
We can sunset this PR in favour of #719? |
|
either works, #719 has this commit and one more for labels |
oavdeev
force-pushed
the
rfc-1123-job-names
branch
from
78d66e9
to
20a684d
Compare
|
Great! Merged #719. We can sunset this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a known TODO item on K8S API to make job names always-valid