Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance Dockerfile #281

Merged
merged 4 commits into from
Sep 18, 2020
Merged

Enhance Dockerfile #281

merged 4 commits into from
Sep 18, 2020

Conversation

AllMethodGrind
Copy link
Contributor

Updates to Dockerfile include:

  • Reduce the size of final image by copying compiled libraries from transient build container
  • Hide java commands in bash scripts for simpler CLI usage

Example usage:

docker run -it --rm -v "${PWD}:${PWD}" -w="${PWD}" --name IMPAnalyzer photon IMPAnalyzer .

@codecov
Copy link

codecov bot commented Aug 24, 2020

Codecov Report

Merging #281 into master will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #281      +/-   ##
============================================
+ Coverage     67.86%   67.89%   +0.03%     
- Complexity     1609     1722     +113     
============================================
  Files           158      167       +9     
  Lines         11226    11565     +339     
  Branches       1701     1728      +27     
============================================
+ Hits           7618     7852     +234     
- Misses         2798     2904     +106     
+ Partials        810      809       -1     
Impacted Files Coverage Δ Complexity Δ
...netflix/imflibrary/st0377/header/GenericTrack.java 79.41% <0.00%> (-20.59%) 5.00% <0.00%> (+4.00%) ⬇️
...om/netflix/imflibrary/exceptions/IMFException.java 78.94% <0.00%> (-14.81%) 5.00% <0.00%> (ø%)
...in/java/com/netflix/imflibrary/IMFConstraints.java 41.69% <0.00%> (-1.71%) 27.00% <0.00%> (+1.00%) ⬇️
...brary/st2067_2/CompositionModel_st2067_2_2013.java 74.80% <0.00%> (-1.30%) 28.00% <0.00%> (+9.00%) ⬇️
...lix/imflibrary/st2067_2/IMFMarkerResourceType.java 77.77% <0.00%> (-1.17%) 4.00% <0.00%> (ø%)
...brary/st2067_2/CompositionModel_st2067_2_2016.java 77.61% <0.00%> (-1.03%) 27.00% <0.00%> (+10.00%) ⬇️
...com/netflix/imflibrary/writerTools/IMPBuilder.java 80.71% <0.00%> (-0.95%) 27.00% <0.00%> (ø%)
...ry/st2067_201/IABSoundfieldLabelSubDescriptor.java 30.30% <0.00%> (-0.95%) 2.00% <0.00%> (ø%)
...com/netflix/imflibrary/st0377/HeaderPartition.java 77.49% <0.00%> (-0.86%) 139.00% <0.00%> (+13.00%) ⬇️
.../main/java/com/netflix/imflibrary/Colorimetry.java 92.59% <0.00%> (-0.75%) 8.00% <0.00%> (ø%)
... and 57 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d646f2...c015c2c. Read the comment docs.

@cconcolato cconcolato merged commit 6c85820 into Netflix:master Sep 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants