Update data before scheduling a repo

Netflix · Mar 19, 2018 · c97cca7 · c97cca7
1 parent 92027d8
commit c97cca7
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/repokid/cli/repokid_cli.py b/repokid/cli/repokid_cli.py
@@ -1029,6 +1029,8 @@ def main():
         return repo_all_roles(account_number, dynamo_table, config, hooks, commit=commit, scheduled=False)
 
     if args.get('schedule_repo'):
+        LOGGER.info('Updating role data')
+        update_role_cache(account_number, dynamo_table, config, hooks)
         return schedule_repo(account_number, dynamo_table, config, hooks)
 
     if args.get('show_scheduled_roles'):

diff --git a/repokid/utils/roledata.py b/repokid/utils/roledata.py
@@ -380,13 +380,13 @@ def _get_repoable_permissions(account_number, role_name, permissions, aa_data, n
 
     for permission_name, permission_decision in potentially_repoable_permissions.items():
         if permission_name.split(':')[0] in IAM_ACCESS_ADVISOR_UNSUPPORTED_SERVICES:
-            LOGGER.warn('skipping {}'.format(permission))
+            LOGGER.warn('skipping {}'.format(permission_name))
             continue
 
         # we have an unused service but need to make sure it's repoable
         if permission_name.split(':')[0] not in used_services:
             if permission_name in IAM_ACCESS_ADVISOR_UNSUPPORTED_ACTIONS:
-                LOGGER.warn('skipping {}'.format(permission))
+                LOGGER.warn('skipping {}'.format(permission_name))
                 continue
 
             permission_decision.repoable = True