update deps to pull in netty 4.1.3.Final #392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the rxhttp client used by servo-atlas so we get netty 4.1.0.Final.
Servo was using a long deprecated constructor in
RxHttp that was removed.
```
/home/travis/build/Netflix/servo/servo-atlas/src/main/java/com/netflix/servo/publish/atlas/AtlasMetricObserver.java:97: error: constructor RxHttp in class RxHttp cannot be applied to given types;
this(config, commonTags, pollerIdx, new HttpHelper(new RxHttp(new BasicServerRegistry())));
^
required: Config,ServerRegistry
found: BasicServerRegistry
reason: actual and formal argument lists differ in length
1 error
:servo-atlas:compileJava FAILED
```
This change passes in an empty config. Note that
previously you could get the static config instance
from archaius1. With archaius2 there is no static
config, so if you are not injecting the configuration
you do not have any access to the configuration used by
the rest of the application.
brharrington
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the rxhttp client used by servo-atlas so
we get netty 4.1.0.Final.