allow uri to be specified as string #371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds overrides for setting the request URI as a `String` instead of a `java.net.URI`. There are two main reasons: * The URI class is fairly strict on the format and will fail for many URIs that are common in practice. Using the string we can avoid that issue. * Some servers, e.g. akka, have their own URI model classes and this avoids needing to convert to string and reparse as a URI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds overrides for setting the request URI as a
Stringinstead of ajava.net.URI. There aretwo main reasons:
and will fail for many URIs that are common
in practice. Using the string we can avoid
that issue.
model classes and this avoids needing to
convert to string and reparse as a URI.