Fix issues with ArrayTagSet's hashCode #996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
kilink
commented
Oct 5, 2022
•
kilink
commented
- Only read cached hash code field once to avoid running afoul of edge case involving re-ordering of operations permitted by the Java memory model. (see this blog post for details).
- Make computed hash code consistent with Arrays.hashCode (e.g., ArrayTagSet.EMPTY hashes to 1).
- Only read cached hash code field once to avoid running afoul of edge case involving re-ordering of operations permitted by the Java memory model. - Make computed hash code consistent with Arrays.hashCode (e.g., ArrayTagSet.EMPTY hashes to 1).
kilink
force-pushed
the
arraytagset-hash-code-fix
branch
from
74d1cb3
to
14446fe
Compare
brharrington
approved these changes
Oct 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.