This repository has been archived by the owner on Jun 7, 2022. It is now read-only.
Updating step scaling policy alarm configuration #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbak
approved these changes
Dec 6, 2021
andrew-leung
approved these changes
Dec 6, 2021
| @@ -54,6 +54,8 @@ message AlarmConfiguration { | |||
| // The statistic for the metric associated with the alarm, other than | |||
| // percentile. | |||
| oneof statisticOneof { Statistic statistic = 8; } | |||
|
|
|||
| repeated MetricDimension metricDimensions = 9; | |||
There was a problem hiding this comment.
Can you add a comment to this field? All of the other metrics have a comment and I don't think it would be clear to a user if/what they should set here. I believe the other comments were derived from the comments on their AWS equivalents.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Step scaling policy configuration needs to support custom metric dimensions in order to build scaling on metrics that are not tagged with AutoScalingGroup (default)