This repository has been archived by the owner on May 14, 2022. It is now read-only.
Step scaling custom dimensions #1191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Step scaling policy configuration currently supports a default metric dimension - AutoScalingGroup
For other cloud-watch metrics that are not tagged with AutoScalingGroup, we didn't have a way to create a step scaling auto scaling policy.
This code change is aimed at supporting additional metric dimensions in creating cloud watch alarm configuration that is associated with a step scaling policy.
Note that - the Target tracking policy configuration already supports this feature.