Skip to content
This repository has been archived by the owner on Jan 10, 2023. It is now read-only.

Fix terminate timeout test #129

Merged
merged 2 commits into from
May 21, 2018
Merged

Fix terminate timeout test #129

merged 2 commits into from
May 21, 2018

Conversation

sargun
Copy link
Contributor

@sargun sargun commented May 18, 2018

No description provided.

@codecov
Copy link

codecov bot commented May 18, 2018

Codecov Report

Merging #129 into master will increase coverage by 0.08%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #129      +/-   ##
==========================================
+ Coverage   35.71%   35.79%   +0.08%     
==========================================
  Files          65       65              
  Lines        7353     7358       +5     
==========================================
+ Hits         2626     2634       +8     
+ Misses       4426     4423       -3     
  Partials      301      301
Impacted Files Coverage Δ
executor/runtime/docker/docker.go 51.48% <100%> (+0.73%) ⬆️
launchguard/client/client.go 73.72% <0%> (-1.7%) ⬇️

 * Fix race condition in terminate test using healthchecks
 * Make sure we don't terminate too quickly
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1087

  • 0 of 12 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.01%) to 25.901%

Changes Missing Coverage Covered Lines Changed/Added Lines %
executor/runtime/docker/docker.go 0 12 0.0%
Totals Coverage Status
Change from base Build 1077: -0.01%
Covered Lines: 2408
Relevant Lines: 9297

💛 - Coveralls

@sargun sargun merged commit e186e30 into master May 21, 2018
@sargun sargun deleted the fix-terminate-timeout-test branch May 21, 2018 22:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants