This repository has been archived by the owner on Jan 10, 2023. It is now read-only.
Minor documentation fixes #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corindwyer
reviewed
Jun 27, 2018
README.md
Outdated
| 1. gometalinter --install | ||
| 1. go get -u github.com/kardianos/govendor | ||
|
|
||
| You would also need to make sure that your build environment (i.e. VM) has the following commands prior to building |
README.md
Outdated
| gometalinter --install | ||
| go get -u github.com/kardianos/govendor | ||
| 1. go get -u github.com/alecthomas/gometalinter | ||
| 1. gometalinter --install |
There was a problem hiding this comment.
Aren't numbered lists in markdown the actual numbers such as:
1.
2.
3.
?
sargun
approved these changes
Jun 27, 2018
Pull Request Test Coverage Report for Build 1485
💛 - Coveralls |
Codecov Report
@@ Coverage Diff @@
## master #148 +/- ##
=======================================
Coverage 33.84% 33.84%
=======================================
Files 61 61
Lines 7167 7167
=======================================
Hits 2426 2426
Misses 4443 4443
Partials 298 298 |
corindwyer
approved these changes
Jun 28, 2018
|
@rickkw feel free to hit the merge button when ready. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Fixed a few documentation errors